Include SUNDIALS 3.2.1 in ThirdParty/ subdir #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the latest compatible SUNDIALS version (3.2.1) in the ThirdParty/ subdirectory. The packaged SUNDIALS code only contains IDAS, iterative linear solvers, and the serial vector implementation. The CMake build system is stripped down accordingly. The packaged SUNDIALS is selected and built by default. If a custom SUNDIALS installation is requested, the option ENABLE_PACKAGED_SUNDIALS has to be disabled upon CMake configuration. In this case, the standard search procedure is executed (set SUNDIALS_ROOT environment or CMake variable).
Updates the build instructions. SUNDIALS is marked as optional and it is described how a manually compiled version can be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the latest compatible SUNDIALS version (3.2.1) in the ThirdParty/ subdirectory. The packaged SUNDIALS code only contains IDAS, iterative linear solvers, and the serial vector implementation. The CMake build system is stripped down accordingly.
The packaged SUNDIALS is selected and built by default. If a custom SUNDIALS installation is requested, the option ENABLE_PACKAGED_SUNDIALS has to be disabled upon CMake configuration. In this case, the standard search procedure is executed (set SUNDIALS_ROOT environment or CMake variable).
This PR fixes #64 in the sense that CADET no longer requires a SUNDIALS installation. Compare the first option in #69 (comment).