Register snippet PII improvements #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add &redirectUnsetDefaultParams to Register snippet - Allow &redirectUnsetDefaultParams to disable the setting of pii params in redirect urls - Add &redirectUnsetDefaultParams to default property sets for Register and ConfirmRegister snippets - Add desc to lexicons
|
Looks good, I will check that soon. |
|
Just tested the controller / processor changes. In terms of functionality this PR provides, it works. Thanks @davidpede for your contribution. |
|
Considering GDPR is tomorrow - could this PR be looked at? |
|
Please check the upcoming 1.9.6 version https://github.com/Jako/Login/raw/master/_packages/login-1.9.6-pl.transport.zip |
|
Available now with 1.9.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes the setting of 'username' and 'email' url params optional by adding
&redirectUnsetDefaultParams=`1`to your Register snippet call. Addresses #122Reason
Essential for GDPR and Google Analytics T&C compliance.
Changes