Skip to content
This repository has been archived by the owner on Mar 8, 2021. It is now read-only.

Update PHPMailer and added new class "MODxMailer" #72

Closed
wants to merge 3 commits into from
Closed

Update PHPMailer and added new class "MODxMailer" #72

wants to merge 3 commits into from

Conversation

yama
Copy link
Collaborator

@yama yama commented Jun 8, 2011

Update PHPMailer and added new class "MODxMailer"

@netProphET
Copy link
Member

Hello yama,
Has this mailer been tested with PHP 5?
I will follow up with some more comments shortly.
Thanks,
Mike

@yama
Copy link
Collaborator Author

yama commented Sep 1, 2011

Hello Mike.
Yes, it tested enough with PHP5.
It is firmly operating by a lot of sites.
thanks.

@netProphET
Copy link
Member

Hello yama,
I just realized that 2.0.4 is the version used in Revolution as well :)
Have you looked at Revolution's modMail abstract class and modPHPMailer which extends modMail and wraps PHPMailer? In Revolution it's used as a service class (a singleton). I don't see any specific multibyte handling in the Revo classes, but I wonder if they work for multibyte langauges? Revo's class allows many other functions, including header manipulation and attachments.
It would be good if we could leverage existing code from Revo to keep Evo up to date. It will take some testing. Please let me know if you have any ideas on this. Thanks!

@yama
Copy link
Collaborator Author

yama commented Dec 19, 2013

This is solved.

@yama yama closed this Dec 19, 2013
Deesen pushed a commit to Deesen/evolution that referenced this pull request Jul 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants