Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 fix with parse_str missing second param #14

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jaygilmore
Copy link
Member

PHP requires the second parameter for parse_str().

PHP requires the second parameter for `parse_str()`.
@Mark-H Mark-H mentioned this pull request May 13, 2022
Copy link

@BenceSzalai BenceSzalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this patch fixes the PHP error when not used as an output filter, it breaks it still when being used as one. A proper fix would look like this from line 51:

if (isset($options)) {  // if we're being called as an output filter, set variables for any options
	parse_str($options, $optionsArray);
	extract($optionsArray);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants