Change of the name and description in the top menu of Form Customization #14353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paces." This reverts commit b4612fb. # Conflicts: # core/model/phpthumb/phpthumb.class.php
* '2.x' of ssh://github.com/gregcrown/revolution: (39 commits) Fix regression in resourcelist that prevents parents from working correctly Improve wording in variables Refactored tag input renreder to fix rendering with empty options list Fixed issues with tab width and very long strings in the tabs Fixing a php error for an invalid id property Revert compiled css files Small fix Fix position slide-in/slide-out button of Resource tree Move uri and uri_overide to settings-right-box-left region Fix disaligned right column when left column not displayed Fix context menu on user page, on "Access Permissions" Fixed #12302 Fix empty Constraint column in FC if constraint value is 0 Fixed issue #5537 Don't remove the trailing slash when redirecting to the manager after logging in Added explanatory text with MODX tag Added explanatory text with MODX tag Added explanatory text with MODX tag Button style Button style ...
… modPhpThumb class which is managed by MODx.
|
@JoshuaLuckers Indeed, these lexicons are not used anywhere else. |
JoshuaLuckers
added
area-fc
JoshuaLuckers
previously approved these changes
Feb 10, 2019
Merge remote-tracking branch 'upstream/pr/14461' into 2.x * upstream/pr/14461: Restore PHP 5.3 compatibility (while dreaming of 7.1)
…ources with spaces in URL's Merge remote-tracking branch 'upstream/pr/14301' into 2.x * upstream/pr/14301: Removed URL detection from core phpThumb class and moved the logic to modPhpThumb class which is managed by MODx. Bugfix for thumbnails not rendering for s3 image URL's with spaces. Bugfix for thumbnails not rendering for s3 image URL's with spaces.
* upstream/pr/14460: Back to CRLF - if thats the cause of the long diff Fix using wrong option for upload_images
* upstream/pr/14357: Update modx.panel.context.js Fix #14342
* upstream/pr/14433: Fix using wrong option Check extracted files for allowed extensions by option
|
@MarkH please check. |
Returned a dot at the end for full sentences (confirm, error messages)
* upstream/pr/14476: Remove statistics block Update README.md
Mark-H
requested changes
Apr 25, 2019
There was a problem hiding this comment.
The primary key for installing menu items is the text. I think that means that the current "Manager Customization" menu item would be left in-place, without its lexicon as that's also removed, alongside a new item for FC. That seems to call for an upgrade script that removes the old bespoke_manager menu item on upgrade.
I also think this should be targeting 3.x, not 2.x?
Merge remote-tracking branch 'upstream/pr/14477' into 2.x * upstream/pr/14477: Update phpThumb
* upstream/pr/14495: Fix lexicon key Corrected title in top menu and in section
* upstream/pr/14502: Returned a dot at the end for full sentences Removed points at the end of descriptions of menu items
* upstream/pr/14553: Replaced color with variable Added styles for scroll
|
This PR I close and create a new 3.x base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Change of the name and description in the top menu of Form Customization
Why is it needed?
Fix lexicon keys for name and description Form Customization in the top menu
Related issue(s)/PR(s)
#14352