Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't see any video from Vimeo #10

Closed
1 of 2 tasks
Ibochkarev opened this issue Mar 5, 2019 · 2 comments
Closed
1 of 2 tasks

Don't see any video from Vimeo #10

Ibochkarev opened this issue Mar 5, 2019 · 2 comments

Comments

@Ibochkarev
Copy link
Collaborator

Affected page(s)

https://modxdocs.mhserver.nl/current/en/getting-started/video-quick-start-series

What needs to be improved?

Connect the player to play the video on the page

Relevant versions

The problem affects the following version(s):

  • 2.x (current)
  • 3.x
@Ibochkarev
Copy link
Collaborator Author

@Mark-H
Copy link
Collaborator

Mark-H commented Mar 15, 2019

I think the simplest solution is to replace it with the actual HTML to embed it. I haven't tried it with our particular markdown parser (league/commonmark) to see if that defaults to preventing embeds, but valid HTML should work.

An alternative could be a plugin that identifies a vimeo/youtube link and turns it into an embed: https://gist.github.com/0b10011/9017f38586404f161298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants