Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to orbit determination types #149

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Minor improvements to orbit determination types #149

merged 5 commits into from
Jan 30, 2024

Conversation

moeyensj
Copy link
Owner

@moeyensj moeyensj commented Jan 6, 2024 •
edited

  • Uses adam_core's OrbitDeterminationObservations class as inputs to the low level IOD and OD functions
  • Modifies the FittedOrbits and FittedOrbitMembers classes to match those used by adam_core (we can full replace them at a later date)
  • Adds calculate_max_outliers
  • Fixes how the propagator is passed to differential correction and the orbit merging functions

@moeyensj moeyensj changed the title Use adam_core's fit_least squares Minor improvements to orbit determination types Jan 30, 2024
akoumjian
akoumjian requested changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@akoumjian akoumjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with exception of instantiating propagator default kwarg.

thor/orbits/od.py Outdated Show resolved Hide resolved
@akoumjian akoumjian self-requested a review January 30, 2024 18:07
@moeyensj moeyensj merged commit 4d093c0 into main Jan 30, 2024
4 of 5 checks passed
@moeyensj moeyensj deleted the v2.0-orbit-determination branch January 30, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoumjian akoumjian akoumjian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moeyensj @akoumjian