Adding support for passing previous template resolutions into variable templates #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=========================================
+ Coverage 97.52% 97.62% +0.1%
=========================================
Files 8 8
Lines 242 253 +11
Branches 71 74 +3
=========================================
+ Hits 236 247 +11
Misses 6 6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a template is resolved we add it to the context. The first time a template is resolved the it is added to the resolutions just as a value. However if that same template is resolved again then we convert the value into an array of values for that template. This should make it a bit easier to work with if your only using a template once in a string, but still supports using it multiple times.