-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #86
Merged
Merged
Refactor #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json # package.json
… into more logical files
…e up in moving tests.
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=========================================
+ Coverage 97.75% 98.46% +0.7%
=========================================
Files 9 12 +3
Lines 267 260 -7
Branches 76 80 +4
=========================================
- Hits 261 256 -5
+ Misses 6 4 -2
Continue to review full report at Codecov.
|
closes #80 |
This was referenced Apr 26, 2018
Closed
This was referenced Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed or moved almost everything! should be a bit easier to follow and reason about now :).
obviously loads of changes and things I've probably forgotten about but a few important things:
A few things may look like they've been removed, for instance variables and dictionary contexts, but are just implemented in a slightly differently now. Changed
splain.process
to take in an options parameter to keep new features neater and stop parameter creep. This meansvariables
and the newly nameddictionaryName
can be passed in with that. There are examples in the tests.A couple of things have been removed. I took the caching out as it was causing us problems and not sure the pay off was worth it. An
array.reduce
should be quick enough. I also removed previous resolutions with a view to implement a more detailed output mechanism in the near future.Also moved any tests that were testing Splain as a whole out of the lib folder. These are now at the root level in
splain.test
. Cool thing about this is it then runs the tests over both the compiled version and the library!(still working out a few things with context ordering so not actually ready for merge just thought you might wanna check it out 😄 )