-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum temperature logic to defer to slicer during printing #7
Update minimum temperature logic to defer to slicer during printing #7
Conversation
Thank you! This seems to make sense and looks correct but I'm going to need to wait until I'm reunited with my printer in about 10 days to test / experiment... |
@moggieuk updating to say that I've had time to test this with many prints and it's working as I'd expect! Loads from PLA (210º) to PETG (255º) and back are working well with no downtime to wait for heating |
This looks good. Can you help me with two things so I can merge easily:
|
|
#13 |
Issue:
There are two main things this PR addresses:
min_temp_extruder
is set to something higher than your printing temp,min_temp_extruder
will be set as your new printing temp during the swap. You could just setmin_temp_extruder
lower, but I have mine set at 230 to work for PLA, PETG, TPU, ABS, and nylon since this allows me to remove filament without knowing/caring what kind it is. But during a print we should defer to the slicer's temps insteadFix Description:
See code comments, but at a high level:
_set_above_min_temp
to defer to the slicer when printing and renames to better reflect new behaviourcan_extrude
as a safeguard_load_extruder
to ensure the target temp has been reached before attempting a load. This should be unneeded in practice, but better safe than sorry!GitHub Issues Resolved:
None