Made ManagedTrackerHost timer a daemon thread #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massdosage
reviewed
Jul 6, 2017
| @@ -58,7 +58,7 @@ | |||
| } | |||
|
|
|||
| ManagedTrackerHost(InetSocketAddress address) { | |||
| this(address, new Timer(), Clock.INSTANCE); | |||
| this(address, new Timer(true), Clock.INSTANCE); | |||
There was a problem hiding this comment.
Looks OK to me, @hrchu any thoughts on this based on how you're using moji? Are there any use cases where one would want the timer to prolong the life of the application? If someone did want that I think they should probably do it within their app rather than having it be a side effect of this Timer.
There was a problem hiding this comment.
@massdosage agree with you. @cdwhatcott thanks for contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the boolean flag to the Timer constructor to make it's associated thread a daemon. The reason for this change is because I am using Moji client in a console application and the timer threads are preventing the application from terminating after it has completed its processing.