Added Preview and stored in db #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arpit3018
commented
Dec 27, 2018
arpit3018
commented
- Added youtube url preview
- Stored the data received by youtube api to database
- Modified Readme.md
arpit3018
force-pushed
the
youtube_api
branch
from
71b1eec
to
5c60d58
Compare
mohitkh7
reviewed
Dec 30, 2018
learn/views.py
Outdated
| if "watch" in url: | ||
| #Identifies that it is a video | ||
| temp,slug = url.split("watch?v=") | ||
| import os |
There was a problem hiding this comment.
As per PEP8 convention, import should not be inside any function or class. It should be on the top of the file.
learn/views.py
Outdated
| #Identifies that it is a video | ||
| temp,slug = url.split("watch?v=") | ||
| import os | ||
| api_key = os.getenv("YOUTUBE_API_KEY") |
There was a problem hiding this comment.
logic to fetch confidential keys from env variable should be put in settings.py and not inside this function.
README.md
Outdated
| 1. Visit the url https://console.cloud.google.com/apis/ | ||
| 2. Sign in with your google account. | ||
| 3. Search for **YouTube Data API v3** and enable it. | ||
| 4. After enabling to go credentials present in the left navbar. |
| @@ -0,0 +1,20 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
This migrations should be merged into single migration file.
|
|
||
| url_entires = {} | ||
|
|
||
| def youtubeResource(request): |
There was a problem hiding this comment.
Add relevant comments which will make it easy for other to understand logic behind code.
learn/views.py
Outdated
| api_key = os.getenv("YOUTUBE_API_KEY") | ||
| try: | ||
| contents = urlreq.urlopen("https://www.googleapis.com/youtube/v3/videos?part=snippet%2CcontentDetails%2Cstatistics&id="+slug+"&key="+api_key).read() | ||
| print(type(contents)) |
learn/views.py
Outdated
| flag = True | ||
| if "watch" in url: | ||
| #Identifies that it is a video | ||
| temp,slug = url.split("watch?v=") |
There was a problem hiding this comment.
instead of temp variable use _ (underscore) to handle unnecessary data returned by split statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.