-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add functionality for writing migrations. #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moigagoo
changed the title
Add minimal functionality for writing basic migrations.
Add functionality for writing migrations.
Sep 19, 2019
moigagoo
changed the title
Add functionality for writing migrations.
[WIP] Add functionality for writing migrations.
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPD: working on this PR allowed me to extend my knowledge on Nim metaprogramming and rewrite the internals of Norm. The code is now simpler and more powerful. Most importantly, this refactoring allowed me to implement proper migration primitives with proper SQLite and PostrgeSQL queries. So, the information under the horizontal line is no longer valid.
Here are the migration primitives I'm going to ship with this PR:
SQLite:
PostgreSQL:
Important: all migration primitives are to be used after the model has been changed to mirror the changes onto the database.
Also, I've added createTable and dropTable to create and drop individual tables.
The goal is to add a minimal set of templates to allow writing migrations.
So far, I've come to this list of actions:
With these actions, the following kinds of migrations could be implemented:
Add or remove columns, rename table, change column type without data migration:
Rename column, change column type with data migration:
Norm will provide only the means to write migrations. Migration generation and application will be implemented in a separate project.