Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt pyproject.toml #1571

Closed
ThomasWaldmann opened this issue Jan 1, 2024 · 2 comments · Fixed by #1618
Closed

adopt pyproject.toml #1571

ThomasWaldmann opened this issue Jan 1, 2024 · 2 comments · Fixed by #1618
Assignees
Milestone

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Jan 1, 2024

Can be done in 2 steps:

  • there should be a minimal pyproject.toml in any case, giving build system requirements and backend
  • even better, move all metadata from setup.cfg / .py to pyproject.toml (for moin as well as for the misc. other tools used for development)

https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/

Example PR from borg: borgbackup/borg#7997

@ThomasWaldmann
Copy link
Member Author

flake8 is a bit of a troublemaker here as its settings can't live in pyproject.toml, but there is ruff as a nice replacement.

as this tends to be a slightly bigger change, it is best done as a separate PR, as seen there:

borgbackup/borg#7808

@UlrichB22
Copy link
Collaborator

Recommendation from Thomas in #1570:

Replace flake8 by ruff - it integrates better into pyproject.toml.

@ThomasWaldmann ThomasWaldmann self-assigned this Feb 22, 2024
@ThomasWaldmann ThomasWaldmann added this to the 2.0.0a1 milestone Feb 22, 2024
ThomasWaldmann added a commit to ThomasWaldmann/moin that referenced this issue Feb 23, 2024
ruff supports pyproject.toml (and is quite fast).
ThomasWaldmann added a commit to ThomasWaldmann/moin that referenced this issue Feb 24, 2024
ruff supports pyproject.toml (and is quite fast).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants