Few fixes of checking exceptions #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
titusjaka
commented
Aug 13, 2018
titusjaka
commented
- since now we don't want to notify user if something goes wrong. So, I remove checkData.State = EXCEPTION
- if there are 0 metrics in trigger, we want to switch trigger in TTLState instead of NODATA
- since now we don't want to notify user if something goes wrong. So, I remove checkData.State = EXCEPTION - if there are 0 metrics in trigger, we want to switch trigger in TTLState instead of NODATA
borovskyav
reviewed
Aug 13, 2018
| return checkData, nil | ||
| } | ||
| case ErrTriggerHasOnlyWildcards: | ||
| case ErrTriggerHasNoTimeSeries, ErrTriggerHasOnlyWildcards: |
There was a problem hiding this comment.
Ох, ты тут что-то опасное пытаешься сделать.
There was a problem hiding this comment.
Я покопался в логике. Они очень похожие, поэтому я объединил.
checker/check.go
Outdated
| return checkData, nil | ||
| } | ||
| case ErrTriggerHasOnlyWildcards: | ||
| case ErrTriggerHasNoTimeSeries, ErrTriggerHasOnlyWildcards: | ||
| triggerChecker.Logger.Debugf("Trigger %s: %s", triggerChecker.TriggerID, checkingError.Error()) | ||
| triggerState := ToTriggerState(triggerChecker.ttlState) | ||
| if len(checkData.Metrics) == 0 && triggerState != OK { |
There was a problem hiding this comment.
triggerState != OK не хотим сразу убрать? Это условие нужно тут теперь вообще?
There was a problem hiding this comment.
len(checkData.Metrics) == 0 Точно нужно, ибо мы реально хотим кидать эту ошибку только тогда, когда метрик еще не было
titusjaka
force-pushed
the
hotfix/exception-fixes
branch
from
99986fc
to
079605f
Compare
|
@borovskyav вливаю? |
|
На стейджинге я бы это глянул |
|
Ок, завтра катну |
|
Кажется, всё работает как надо. |
borovskyav
approved these changes
Aug 14, 2018
borovskyav
approved these changes
Aug 14, 2018
|
Ничосе, аж дважды заапрувил =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.