Extract telemetry config and setup telemetry server #482

Pliner · 2020-01-09T20:41:07Z

Must be done before #474.

:-/

coveralls · 2020-01-09T21:01:33Z

Coverage remained the same at 80.482% when pulling b6d7a6f on extract-telemetry-config into d0e8176 on master.

cmd/telemetry.go

cmd/config.go

Outdated

Pliner marked this pull request as ready for review January 10, 2020 06:49

Pliner requested a review from a team January 10, 2020 06:49

beevee added backend refactoring labels Jan 10, 2020

borovskyav suggested changes Jan 10, 2020

View reviewed changes

cmd/telemetry.go Outdated Show resolved Hide resolved

cmd/telemetry.go Show resolved Hide resolved

borovskyav previously requested changes Jan 10, 2020

View reviewed changes

cmd/config.go Show resolved Hide resolved

Pliner requested a review from borovskyav January 11, 2020 06:23

Pliner force-pushed the extract-telemetry-config branch from b62e814 to 77d445c Compare January 11, 2020 06:27

borovskyav previously approved these changes Jan 11, 2020

View reviewed changes

Pliner added 3 commits January 11, 2020 14:50

Extract telemetry config and setup telemetry server

92cd7cc

Fix build

b20ee90

Refactor telemetry configuration

b6d7a6f

Pliner dismissed borovskyav’s stale review via b6d7a6f January 11, 2020 09:50

Pliner force-pushed the extract-telemetry-config branch from 77d445c to b6d7a6f Compare January 11, 2020 09:50

borovskyav approved these changes Jan 11, 2020

View reviewed changes

Pliner merged commit f55d98d into master Jan 11, 2020

Pliner deleted the extract-telemetry-config branch January 11, 2020 09:59

A1bemuth mentioned this pull request Feb 26, 2020

update configmaps according to moira/#482 moira-alert/helmcharts#4

Merged

Provide feedback