Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract telemetry config and setup telemetry server #482

Merged
merged 3 commits into from Jan 11, 2020
Merged

Extract telemetry config and setup telemetry server #482

merged 3 commits into from Jan 11, 2020

Conversation

Pliner
Copy link
Contributor

@Pliner Pliner commented Jan 9, 2020 •
edited

Must be done before #474.

:-/

@coveralls
Copy link

coveralls commented Jan 9, 2020 •
edited

Coverage Status

Coverage remained the same at 80.482% when pulling b6d7a6f on extract-telemetry-config into d0e8176 on master.

@Pliner Pliner marked this pull request as ready for review January 10, 2020 06:49
@Pliner Pliner requested a review from a team January 10, 2020 06:49
@beevee beevee added this to Review in 2.6 via automation Jan 10, 2020
borovskyav
borovskyav suggested changes Jan 10, 2020
View reviewed changes
cmd/telemetry.go Outdated Show resolved Hide resolved
cmd/telemetry.go Show resolved Hide resolved
borovskyav
borovskyav previously requested changes Jan 10, 2020
View reviewed changes
cmd/config.go Show resolved Hide resolved
borovskyav
borovskyav previously approved these changes Jan 11, 2020
View reviewed changes
@Pliner Pliner merged commit f55d98d into master Jan 11, 2020
2.6 automation moved this from Review to Done Jan 11, 2020
@Pliner Pliner deleted the extract-telemetry-config branch January 11, 2020 09:59
@A1bemuth A1bemuth mentioned this pull request Feb 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borovskyav borovskyav borovskyav approved these changes

Assignees
No one assigned
Labels
backend refactoring
Projects
No open projects
2.6
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pliner @coveralls @borovskyav @beevee