This repository has been archived by the owner on Jun 21, 2018. It is now read-only.
rewrite self state monitor #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about code coverage decrease? There is a lot of code that need to be tested. |
| func CheckSelfStateMonitorSettings() error { | ||
| if config.Notifier.SelfState.Enabled != "true" { | ||
| if ToBool(config.Notifier.SelfState.Enabled) { | ||
| return nil |
There was a problem hiding this comment.
It seems to bug.
If self check enabled, we exit from function and do not check contact settings
|
Starting to write tests and found a bug. Look at comment ^ |
|
Yes, it is bug |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.