Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update venv to use a custom name and edit errors #1918

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

ThomasHepworth
Copy link
Contributor

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

An improved version of the following - #1086.

Give a brief description for the solution you have provided

Adds an improved version of the create_venv.sh script and updates some of our existing documentation around using this script and maintaining pyproject.toml.

To summarise, this PR adds:

  • Support for naming the venv on the command line - it defaults to venv if nothing is entered.
  • What I hope is a more useful error message should poetry install fail. This is still breaking on my machine for python versions > 3.8 (from memory) and is centred around complications w/ getting numpy installed.
  • Further documentation pertaining to the maintenance and upkeep of poetry.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

@ThomasHepworth ThomasHepworth merged commit 2a2d24c into master Feb 6, 2024
5 checks passed
@ThomasHepworth ThomasHepworth deleted the update_venv_bash_script branch February 6, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants