Update venv to use a custom name and edit errors #1918
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
An improved version of the following - #1086.
Give a brief description for the solution you have provided
Adds an improved version of the create_venv.sh script and updates some of our existing documentation around using this script and maintaining pyproject.toml.
To summarise, this PR adds:
venv
if nothing is entered.poetry install
fail. This is still breaking on my machine for python versions > 3.8 (from memory) and is centred around complications w/ getting numpy installed.PR Checklist