Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tables in Module wiki #103

Open
aornugent opened this issue Jun 14, 2021 · 11 comments
Open

Fix tables in Module wiki #103

aornugent opened this issue Jun 14, 2021 · 11 comments
Assignees

Comments

@aornugent
Copy link
Contributor

What does the current documentation state?
The module wiki has tables that are not formatted correctly.

Where is this stated?
https://github.com/moja-global/FLINT/wiki/3.4-Module-Science

Why do you want to improve the statement?
Fix the markdown syntax by adding extra spaces.

@shloka-gupta
Copy link
Member

If I am not wrong, just markdown beautifier has to be applied to the document, right?

Can I go for it?

@aornugent
Copy link
Contributor Author

Yes please!

@aornugent aornugent assigned aornugent and shloka-gupta and unassigned aornugent Jun 16, 2021
@shloka-gupta
Copy link
Member

So, I did the required changes,

but while creating a PR I am getting the message :
remote: Permission to moja-global/FLINT.wiki.git denied to chicken-biryani.
fatal: unable to access 'https://github.com/moja-global/FLINT.wiki.git/': The requested URL returned error: 403

@shloka-gupta
Copy link
Member

shloka-gupta commented Jun 16, 2021

These links say that :
"GitHub doesn't support pull requests for the wiki repository, only the main repository"
https://stackoverflow.com/questions/10642928/how-to-pull-request-a-wiki-page-on-github
https://docs.github.com/en/communities/documenting-your-project-with-wikis/adding-or-editing-wiki-pages

@shubhamkarande13
Copy link
Member

shubhamkarande13 commented Jul 11, 2021

@chicken-biryani
I guess that it is not possible to create a PR for a wiki on GitHub. Could you please make a zip file of the wiki folder and upload it to Google Drive and share it here, so that @aornugent can update the wiki from his end? ✌

@aornugent it seems that only users with write access to the repo can push updates to the wiki. 😅

@mehabhalodiya
Copy link

mehabhalodiya commented Aug 8, 2021

I have visited this link: https://github.com/moja-global/FLINT/wiki/3.4-Module-Science

And seen the first table was having some issue of formatting.
I have tried to correct it as below. Let me know if it's alright so that I can complete further!

Preview:
moja2

@aornugent Have a look!

@shloka-gupta
Copy link
Member

shloka-gupta commented Aug 8, 2021

Hey, @mehabhalodiya thank you for doing this!! 😃🎉

Could you put the changes of the wiki folder in a zip file and upload it to Google Drive and share the link over here, in the comment section, as stated by @shubhamkarande13 earlier?
(As Github doesn't support PRs for the wiki repository.)

@mehabhalodiya
Copy link

@chicken-biryani Yes I will put it up but first let me know that is it the way you want the format?

@shloka-gupta
Copy link
Member

@mehabhalodiya
Yes. That is the correct format. However, I think there are a few more tables that require formatting.
Just apply a markdown formatter to the whole document and the work will get done!

@mehabhalodiya
Copy link

https://drive.google.com/file/d/1oUWyhBPpA3DKAzH90cxXknXJl2Ha0QeD/view?usp=sharing

@chicken-biryani @shubhamkarande13 @aornugent PTAL!

@apoorvthedude
Copy link

Hi, Please someone mail to @aornugent to close the issue as the file is formatted by @mehabhalodiya.Now the wiki is in correct format.
She has shared the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants