-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: init and startup issues #61
fix: init and startup issues #61
Conversation
mdebarros
commented
Nov 1, 2021
•
edited
Loading
edited
- fixes for missing dependency dns-packet (updated dockerfile ordering)
- fixed issue with config.js when env var was missing
- fixed audit-resolve
- chore: added automated ci-cd release
- updated circleci config for automated releases
- fixed caching issue with npm dependencies
- updated readme with automated release information
- standardized node version via nvmrc and in circleci config
- added missing dependency dns-packet - fixed issue with config.js when env var was missing - fixed audit-resolve
It looks like As an aside, the organisation of this repo might have caused more pain than it's worth, even though it scopes dependencies better. It could be worth reorganising this repo, or perhaps moving to yarn, as you mentioned it might have better support for internal packages. |
Fresh install (i.e. removed node_modules) does not install the dependency. Also if you are referencing a dependency directly in "our" code, it should be added a dependency in our package regardless if another dependency pulls it in. The reason for that is because we want to control the version that we use in our code. |
Is this not the only usage of that lib?
The dependency specified here?
What am I missing? |
Co-authored-by: Matt Kingston <mattkingston@gmail.com>
…s-oracle-pathfinder into fix/init-and-startup-issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've basically ignored the CI additions in this PR; assuming they're pretty standard across ML repos.