Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init and startup issues #61

Merged
merged 17 commits into from
Nov 1, 2021

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Nov 1, 2021

  • fixes for missing dependency dns-packet (updated dockerfile ordering)
  • fixed issue with config.js when env var was missing
  • fixed audit-resolve
  • chore: added automated ci-cd release
    • updated circleci config for automated releases
    • fixed caching issue with npm dependencies
    • updated readme with automated release information
    • standardized node version via nvmrc and in circleci config

- added missing dependency dns-packet
- fixed issue with config.js when env var was missing
- fixed audit-resolve
@partiallyordered
Copy link
Contributor

It looks like dns-packet is present in the internal pathfinder lib dependency manifest. I don't think it shouldn't be necessary/present in the top-level manifest, should it?

As an aside, the organisation of this repo might have caused more pain than it's worth, even though it scopes dependencies better. It could be worth reorganising this repo, or perhaps moving to yarn, as you mentioned it might have better support for internal packages.

@mdebarros
Copy link
Member Author

It looks like dns-packet is present in the internal pathfinder lib dependency manifest. I don't think it shouldn't be necessary/present in the top-level manifest, should it?

Fresh install (i.e. removed node_modules) does not install the dependency. Also if you are referencing a dependency directly in "our" code, it should be added a dependency in our package regardless if another dependency pulls it in.

The reason for that is because we want to control the version that we use in our code.

@partiallyordered
Copy link
Contributor

Is this not the only usage of that lib?

const dnsPacket = require('dns-packet');

The dependency specified here?

What am I missing?

Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@partiallyordered partiallyordered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've basically ignored the CI additions in this PR; assuming they're pretty standard across ML repos.

@mdebarros mdebarros merged commit 80da855 into mojaloop:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants