Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #312: Don't overwrite existing license file #360

Merged
merged 1 commit into from
May 3, 2023
Merged

Fixes issue #312: Don't overwrite existing license file #360

merged 1 commit into from
May 3, 2023

Conversation

Vlatombe
Copy link
Contributor

@Vlatombe Vlatombe commented Dec 16, 2019 •
edited
Loading

When using organizeLicensesByDependencies=true, if you have several
dependencies with the same license, and the same dependency appears
in the dependency tree with different versions/types, then the cached
file will be copied several times over to the destination, which can
already exist.

@Vlatombe
Copy link
Contributor Author

The failing test download-licenses-configured fail the same for me locally on master branch...
The other one PR-33 seems to be flaky, can't reproduce the failure locally.

raul-arabaolaza
raul-arabaolaza approved these changes Dec 18, 2019
View reviewed changes
Copy link

@raul-arabaolaza raul-arabaolaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm I have been affected by this and this fixes it

@Vlatombe Vlatombe requested a review from ppalaga January 21, 2020 14:19
@batmat batmat self-requested a review January 23, 2020 15:48
batmat
batmat approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm going to test this locally too, before and after given the apparent flakiness. If things go well enough, I'll see if I can release.

@olamy olamy closed this Feb 13, 2020
@batmat
Copy link
Member

batmat commented Feb 17, 2020

Seems like this got closed unintendedly?

@batmat batmat reopened this Feb 17, 2020
@olamy
Copy link
Member

olamy commented Mar 15, 2020

@batmat really seems to be a github bug

@olamy olamy added the bug label May 2, 2023
@Vlatombe
Fixes issue mojohaus#312: Don't overwrite existing license file
e2ac9ce 
When using organizeLicensesByDependencies=true, if you have several
dependencies with the same license, and the same dependency appears
in the dependency tree with different versions/types, then the cached
file will be copied several times over to the destination, which can
already exist.
@olamy olamy merged commit f472a4d into mojohaus:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raul-arabaolaza raul-arabaolaza raul-arabaolaza approved these changes

@batmat batmat batmat approved these changes

@ppalaga ppalaga Awaiting requested review from ppalaga

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vlatombe @batmat @olamy @raul-arabaolaza