Expose the Lock ID on the locks page

[stuartskelton]

Summary

Expose the lock ID on the Minion admin locks page

Motivation

I employ locks to manage job execution across multiple worker boxes. However, apart from querying the database, I'm unable to determine whether the locks are being rotated. The expiration time decreasing provides some indication, but if the jobs finish within a minute, I can't tell solely from the lock screen whether they are cycling or being held for that minute.

Since it's only retrieving the ID, which would be part of the index, there should be no slowdown in the database.

References

Sorry this is a drive by pull request

[kraih]

I've not been in a situation where i was interested in the lock id personally. But the reasoning makes sense.

[kraih]

Actually, there is documentation changes missing. And adding a small test to pg_admin.t also wouldn't be hard.

Pull request has been modified.

[stuartskelton]

Thanks for the pointers.

I have added the changes and added the test.

I also took the time to add some tests for the status endpoint for the locks too.

[kraih]

Don't write your own Changes entries please, those are done by the maintainers.

[kraih]

Instead it needs to be mentioned in the documentation, like the other fields.

[stuartskelton]

you are correct, I have corrected this.

[kraih]

And don't forget to squash your commits when you are ready for review.

Pull request has been modified.

[kraih]

There are multiple places where this needs to be added. Also the fields are in alphabetical order.

[stuartskelton]

Updated Backend.pm, I think this was the only other place I neede

[kraih]

Also a perltidy fix is needed. There will be a new Minion release in a few hours, if the mentioned points are resolved this PR can be included.

Pull request has been modified.

[stuartskelton]

ok,

PT'ed the test.
Added the docs to the Backend.pm
And I found the Jobs command that spits out the lock data. So I updated that too.