-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TZ indicators: UTC and ±HH:MM #56
Conversation
This allows for a common UTC timestamp format, recognizable to `date' among others, to be used.
Assuming all current tests pass, could you possibly add some more tests for these features? That way I can just merge, otherwise I'll look at this some time in the next couple of days and add tests myself. Thanks a lot! |
There seems to be a problem with the tests. A clean clone from master fails in test_parse_guess_gr:
This test and the one after are the only two that fail; commenting them out leads to success. I will write some some tests for the TZ stuff but I am not sure what to be done about these year tests. |
Interesting. Could you post your ruby version and current timezone, please. Thanks for adding those tests! |
|
Strange, I can't reproduce this failure, and everyone I've asked can't reproduce it. I'll have a closer look at it tomorrow and merge this pull |
Did anyone else try on Linux?
|
Hah, nice. Yeah I have a repro on Ubuntu 10.10 on a VPS. I'll look more into this tomorrow. Thanks! |
TZ indicators: UTC and ±HH:MM
Kind sir, please accept these patches to allow Chronic to recognize two common TZ indicators.