Should throw errors

[ConradIrwin]

Trying to do things like

Grit::Repo.new("/path/to/nonbare/repo").git.commit({}, '-a', '-m', 'hello', '-author', 'fred')

fails silently. I had to fire up git to try and work out what the problem could be (in this case a mal-formed author parameter)

[davetron5000]

Grit.debug = true can help figure out what it's doing, but I, too, wouldn't mind errors to be generated. I suspect that git doesn't set useful exit codes, tho

[nirvdrum]

git does. I think the real problem is the use of popen3, which doesn't capture exit status codes. popen4 does, however, so that may be the way to go.

[floehopper]

I want to have Grit fail fast by raising an exception if any shell commands have a non-zero exit status. A classic example of this is when you don't have git in your environment's path.

It looks like some work has been done on this - see SHA: 889adf5 - but I can't see how I pass the :raise option into the Grit commands. Am I missing something?

Thanks.

[ohookins]

I found that while Grit logs problems, something critical like the git tool not being present/found means that Git.init will silently fail but when that passes back to Git::Repo.initialize there is no repository in existance and a misleading exception is thrown.

Let me know if this deserves a separate issue.

[bkeepers]

Grit is no longer maintained. See #183 and check out libgit2/rugged.