Loose bytesize fix #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"LooseObjectError: size mismatch" by committing non-ASCII content. String#length returns number of characters in the encoding of the string. Instead, we should use String#bytesize.
|
Ah, thanks! Sorry, I forgot to check the pull requests before pushing out 1.4.1 this morning. I'll probably do another patch release with this bug fix soon. |
|
So far, no patch release has been released, this breaks gollum in a rather unfortunate way for any UTF8 character in the wiki text, could this fix please be released? |
|
I just ran into this on our production wiki. Any chance this could be merged into a release? This really breaks things in a pretty major way... |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a ruby 1.9 encoding problem,
"LooseObjectError: size mismatch" by committing non-ASCII content.
String#length may return number of characters in the encoding of the string. Instead, we should use String#bytesize.
P.S. I found this problem when I tried to get a gollum site worked.