New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanup of tests and test artifacts #451

Merged

cpjolicoeur merged 2 commits into master from nd/remove-warnings

Apr 10, 2024

Contributor

noahduncan commented Apr 10, 2024

Two things here:

Some warnings were generated during tests due to the sequencing of when the new routes for posts pages were added. Those have been fixed by shifting the patch for the routes higher up in the test sequence.
Some files generated during the support tests were not cleaned up appropriately after test run. Adding some additional rm -rf lines to the cleanup function tidies things up neatly.

noahduncan added 2 commits

April 10, 2024 10:13


          Update cleanup for support test

7a6b68f


          Fix warnings due to not having routes at compilation

d202d63

noahduncan requested a review from cpjolicoeur

April 10, 2024 17:26

cpjolicoeur approved these changes

View reviewed changes

cpjolicoeur merged commit ca7ace3 into master

4 checks passed

cpjolicoeur deleted the nd/remove-warnings branch

April 10, 2024 18:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet