Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when trying to retrieve city when error response occured #15

Merged
merged 1 commit into from
Feb 2, 2015

Conversation

tanraya
Copy link
Contributor

@tanraya tanraya commented Feb 2, 2015

I recently fixed a following error:

> Ipgeobase.lookup('127.0.0.1').city
NameError: uninitialized constant Ipgeobase::IpMetaData::Iconv

This error occurs when we get a 'not found' response from a web service:

<?xml version="1.0" encoding="windows-1251"?>
<ip-answer>
<ip value="127.0.0.1"><message>Not found</message></ip>
</ip-answer>

Please bump gem version after applying this PR.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.86% when pulling 0abeac4 on tanraya:fix-local-ip-bug into b9f4aaa on mokevnin:master.

mokevnin added a commit that referenced this pull request Feb 2, 2015
Fix bug when trying to retrieve city when error response occured
@mokevnin mokevnin merged commit e9568c2 into mokevnin:master Feb 2, 2015
@mokevnin
Copy link
Owner

mokevnin commented Feb 2, 2015

thanks you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants