Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added session db listener to sessions based on tokens #4159

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

harmbrugge
Copy link
Member

Fixes #3902

What are the main changes you did:

  • The MolgenisSessionManagerDatabaseListener was not added to Session based on tokens I added this
  • Therefore the python client - when used via a token - did not update the meta data when changes were made

how to test:

  • Go to the webinterface
  • Add metadata using the py client using token based authorization
  • See the meta data update without needing to log in again

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link
Contributor

@connoratrug connoratrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good , suggest to have @dtroelofsprins test the solution for the reported issue

Copy link

sonarcloud bot commented Aug 26, 2024

@harmbrugge harmbrugge merged commit c332893 into master Aug 26, 2024
5 of 6 checks passed
@harmbrugge harmbrugge deleted the fix/token_session_listener branch August 26, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants