-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New DisGeNET data retrieval and additional features/adjustments (such as HPO retrieval using ontology). #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s specific URI based on HPO/DisGeNET dataset). Allows for reduced number of database requests if HPO parent/child retrieval is separated from DisGeNET database.
…Entity creation (prefix not optional anymore).
…tic final variable.
…ith a collection of phenotypes connected to it).
…single Phenotype.
…rk, bug fix regarding same Phenotype being crossed with different distances, generalisation input phenotypes requirement).
…HPOs are retrieved BEFORE querying).
…fic retrieval from a collection of PhenotypeNetworks.
…one both inside a class and before adding to the respective class).
… for benchmarking.
… traverse manually).
…hen adding Phenotypes was removed to allow for more algorithm flexibility when adding new Phenotypes. Due to this, internal List was replaced by a Map.
…ver at higher values.
…her maxDistance even if the same number of phenotypes were returned (now validates for both determining which phenotypes to visit next and for adding to the network instead of only the latter).
…s still need to implement a static method to support this, though can also be used outside enums themselves as long as enum implemented the interface).
…efiner external usage).
…w optional using different RunMode, et cetera).
…parators (also added a convenience method for file closing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewritten the DisGeNET data retrieval, added phenotype retrieval using HPO ontology, further implemented output file writing, some adjustments for better looking code, adjustments/added unit-tests.