-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/json streaming #87
Merged
dennishendriksen
merged 7 commits into
molgenis:master
from
svandenhoek:feature/json_streaming
Sep 2, 2021
Merged
Feature/json streaming #87
dennishendriksen
merged 7 commits into
molgenis:master
from
svandenhoek:feature/json_streaming
Sep 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennishendriksen
requested changes
Sep 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could you take a look at the code smells reported by Sonar?
- Why introduce deprecated code instead of removing it immediately?
Kudos, SonarCloud Quality Gate passed! |
All code smells fixed except (duplicate code in)
To adhere to semantic version so we don't have to make yet another major release yet. |
dennishendriksen
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@deprecated
5.2.0-SNAPSHOT
gson
Important notes
GeneDiseaseCollectionSerializer
andGeneDiseaseCollectionDeserializer
are now simply children of newly implemented classes without any additional code. As these new classes give the same output (except a slight re-ordering of what is written in the output first), this shouldn't cause any major issues (old tests still succeed after adjusting the validation String that the json format stores the combinations after the genes/diseases/sources).When a new major release is done, deprecated code should be removed.
Checklists
Please update the checklists when steps are completed.
Before merge
After merge