Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/json streaming #87

Merged

Conversation

svandenhoek
Copy link
Collaborator

@svandenhoek svandenhoek commented Aug 31, 2021

Changes

  • Added new package containing code for GeneDiseaseCollection JSON (de)serialization
    • Re-used old JSON (de)serialization where possible
    • Implemented streaming option
    • Made old classes @deprecated
  • Updated version to 5.2.0-SNAPSHOT
  • New dependency: gson

Important notes

GeneDiseaseCollectionSerializer and GeneDiseaseCollectionDeserializer are now simply children of newly implemented classes without any additional code. As these new classes give the same output (except a slight re-ordering of what is written in the output first), this shouldn't cause any major issues (old tests still succeed after adjusting the validation String that the json format stores the combinations after the genes/diseases/sources).

When a new major release is done, deprecated code should be removed.

Checklists

Please update the checklists when steps are completed.

Before merge
  • [test afterwards whether memory issues are resolved on vibe.molgeniscloud.org] Functionality works & meets specs
  • [] Code reviewed
  • [n.a.] Documentation was updated
After merge
  • Added feature/fix to draft release notes
  • Removed merged branches

Copy link
Contributor

@dennishendriksen dennishendriksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Could you take a look at the code smells reported by Sonar?
  2. Why introduce deprecated code instead of removing it immediately?

@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

95.0% 95.0% Coverage
1.5% 1.5% Duplication

@svandenhoek
Copy link
Collaborator Author

1. Could you take a look at the code smells reported by Sonar?

All code smells fixed except (duplicate code in) @deprecated classes/methods.

2. Why introduce deprecated code instead of removing it immediately?

To adhere to semantic version so we don't have to make yet another major release yet.

@dennishendriksen dennishendriksen merged commit 180d176 into molgenis:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants