Improve error message for length assertion #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of the actual length is also included as a parameter of the assert which is used inside the Must.prototype.length implementation. As a result, the error output shows the difference between the actual and the expected length.
|
Hey! Sorry for the belated reply. That seemed like a reasonable suggestion. Thank you! I've merged it in and will release a new version shortly. |
|
Btw, are you the same person as https://github.com/mrHerintsoaHasina? |
|
Yes I am
Le lun. 2 nov. 2020 à 13:37, Andri Möll <notifications@github.com> a écrit :
… Btw, are you the same person as https://github.com/mrHerintsoaHasina?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#73 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AISV5AYPHFXCCNWG7SCFAFLSN2RZJANCNFSM4EUBFVLA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys,
I like very much the js-must project as a test tool in my own project. When searching in the source code, I was interested to make the length assert error message more expressive. I modified the Must.prototype.length implementation to improve the ouput of the error message assertion. In fact, it will be more interesting to show the difference between the expected and the actual length when the assertion fails.
For example,
[2,'a'].must.have.length(3)should return this outputOr
"hello".must.have.length(3)with the output