[11.0][FIX] API call to payments #130
Conversation
robinkeunen
force-pushed
the
11.0-fix-api-call-to-payments
branch
3 times, most recently
from
3ca4e40
to
c49c4c2
Compare
|
|
||
| if "status" in data: | ||
| status = data["status"] | ||
| status = mollie_response.get("status", "undefined") |
There was a problem hiding this comment.
We may need to check that the result returned by mollie does match the transaction ID we sended. Like it's done on line 153 (at the end). Else we should raise an error and report it in the log.
|
|
||
| if status == "paid": | ||
| paidDatetime = mollie_response["paidDatetime"].replace(".0Z", "") |
There was a problem hiding this comment.
standard naming for variable ? paid_datetime ? :)
robinkeunen
force-pushed
the
11.0-fix-api-call-to-payments
branch
from
c49c4c2
to
9c52577
Compare
The API nows only returns a single data dictionary instead of a list. Also, the transaction id must be passed in the url.
robinkeunen
force-pushed
the
11.0-fix-api-call-to-payments
branch
from
9c52577
to
ee2de67
Compare
|
@odoo-mvds can you have a look at this ? We've been using it in production for 3 months now. |
|
Hello, we do not support old versions anymore, however we will have a look at this fix as it's easy to merge. br, |
|
Hi, Thank you for your contribution and for submitting the pull request (PR). As we have informed you, we are no longer maintaining the older version of the project to which your PR applies. We recommend upgrading to the latest version. In case we receive more such complains for the same issue, we will probably reopen the issue. Consequently, we will be closing this PR. We truly appreciate your effort and interest in improving the project and look forward to any future contributions you may have. Best regards, |
The API nows only returns a single data dictionary instead of a list.
Also, the transaction id must be passed in the url.
Previously,
dataargument was overwritten in the function body. I'm tempted to eitherdatadict in the case some other function relies on the content of the data dictdatadict as a best practice to avoid side effects.I chose the latter option.