Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently fails to send over closed connection (client) #224

Open
ashimoon opened this issue Nov 5, 2016 · 0 comments
Open

Silently fails to send over closed connection (client) #224

ashimoon opened this issue Nov 5, 2016 · 0 comments

Comments

@ashimoon
Copy link

ashimoon commented Nov 5, 2016

After a server closes the connection, the connection is marked as closed, but the connection is kept in the endpoint[key] cache.

Later requests to send data over that connection fail silently (Connection.prototype._send checks _closed, silently returns).

This manifests itself in some number of requests succeeding, and then suddenly no more requests succeed, with no error.

I've fixed it locally by having the connection emit a new event "closed". Endpoint re-emits this event, and Agent finally handles it by removing the closed endpoint/connection from Agent.endpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant