update email handling #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moloch--#598 was caused by unicode characters from the user's full name being included in the to header of the validation email. I re-worked the email code to simplify and standardize it: - Email header creation moved into EmailHelpers.py as create_email_headers - This sets the From,To headers properly encoding any unicode, which is what caused 598. - Base64 encoding of the email body/template moved into EmailHelpers.py as get_emaiL_message - This standardizes the creation of an EmailMessage object, setting headers, and attempting the Base64 encoding, falling back to a normal email if it fails - As a bonus, this replaces the function I added previously 'email_rfc2822_compliance', as this solution encompasses that and is more robust - Moved sending code into EmailHelpers.py as send_email_message - Changed from sendmail to send_message since we are using an EmailMessage object now - Updated send_validate_message to use the new functions - Updated create_validate_message to use the new functions - Updated ForgotPasswordHandler to use the new functions - Updated create_reset_message to use the new functions
|
Nice Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#598 was caused by unicode characters from the user's full name being included in the to header of the validation email.
I re-worked the email code to simplify and standardize it:
Email header creation moved into EmailHelpers.py as create_email_headers
Base64 encoding of the email body/template moved into EmailHelpers.py as get_emaiL_message
Moved sending code into EmailHelpers.py as send_email_message
Updated send_validate_message to use the new functions
Updated create_validate_message to use the new functions
Updated ForgotPasswordHandler to use the new functions
Updated create_reset_message to use the new functions