Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization depth changes results in rare cases #124

Open
rlavendomme opened this issue Jun 7, 2022 · 0 comments
Open

Optimization depth changes results in rare cases #124

rlavendomme opened this issue Jun 7, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@rlavendomme
Copy link
Collaborator

Description

With MoloVol v1.0.0 (windows release version).
In rare occasions with specific sets of input file and parameters, different optimization depths lead to slightly different results (observed occurrence: <0.01% difference in result).
MoloVol was designed so that to the optimization depth parameter would change the calculation time but not the results of the calculation.

How to reproduce the issue

One example of this bug occurrences is with the PDB 7K43 (see https://www.rcsb.org/structure/7k43).
With default element radii and following parameters:
Exclude HETATM from pdb file
Crystal unit cell analysis: No
Probe mode: one probe
Probe radius: 3 A
Grid resolution: 0.4 A
Optimization depth: variable

Results with optimization depth 0:
Van der Waals volume: 335010.944 A^3
Probe excluded void volume: 224515.968 A^3
Probe shell volume: 331091.968 A^3

Results with optimization depth 1-2:
Van der Waals volume: 335010.880 A^3
Probe excluded void volume: 224525.376 A^3
Probe shell volume: 331082.624 A^3

Results with optimization depth 3-4:
Van der Waals volume: 335010.944 A^3
Probe excluded void volume: 224525.312 A^3
Probe shell volume: 331082.624 A^3

Some volumes show differences below 0.01%, so much lower than the accuracy of the results. Such differences are not observed with several other parameter sets.
The sum of all three volumes is constant: 890618.88 A^3
So the optimization depth in this particular case seems to affect the limit between the voxel types.

Proposed change

First, we should investigate what is the origin of the bug then see if it's inherent to the octree development with specific combinations of grid resolution and probe radius. Then we can decide how to fix it if it can be fixed without jeopardizing the algorithms.
As the difference is minimal, it does not need to be urgently fixed.

@rlavendomme rlavendomme added the bug Something isn't working label Jun 7, 2022
@rlavendomme rlavendomme changed the title Optimization depth rarely change results Optimization depth change results in rare cases Jul 12, 2022
@rlavendomme rlavendomme changed the title Optimization depth change results in rare cases Optimization depth changes results in rare cases Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant