Crystal unit cell #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main addition is the function to analyze crystal unit cells. I also added extra parameters in the GUI for future features (such as probe mode and probes radii). I made a new source file for functions related to file writing (report, structures, surface maps). Note that I don't use the makefile in the repository so I did not update the makefile.
updated window name to MoloVol fixed note regarding H2O radius not showing completely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added features related to crystal unit cell analysis (see issue #48 ).
Additionally, I added few parameters in the GUI for future features (such as probe mode and probes radii) and added a source file for functions related to file creation (e.g. report).
All the geometric calculations are complicated. Reviewing these parts of the code could prove difficult or extremely time consuming.
I would suggest to not change any part under the CRYSTAL UNIT CELL PROCESSING FUNCTIONS section of model.cpp.