Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

feat: added pagination in products and nodes #759

Merged
merged 4 commits into from
Jan 16, 2023
Merged

feat: added pagination in products and nodes #759

merged 4 commits into from
Jan 16, 2023

Conversation

psin32
Copy link
Contributor

@psin32 psin32 commented Jan 16, 2023

Type

  • Feature

    Implements a new feature

Description

Adds pagination support for products and nodes in the PXM Catalogs endpoint

Dependencies

Other PRs or builds that this PR depends on.

Issues

A list of issues closed by this PR.

Copy link
Collaborator

@samblacklock samblacklock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @psin32 i left one small comment

were you able to validate the changes locally? I don't really have a test store with enough nodes to properly test the pagination!

src/endpoints/catalogs.js Outdated Show resolved Hide resolved
@samblacklock samblacklock changed the title fix: added pagination in products and nodes feat: added pagination in products and nodes Jan 16, 2023
@samblacklock
Copy link
Collaborator

thanks @psin32 i left one small comment

were you able to validate the changes locally? I don't really have a test store with enough nodes to properly test the pagination!

tested locally by @psin32 and confirmed working.

@samblacklock samblacklock merged commit 1268290 into moltin:main Jan 16, 2023
@samblacklock samblacklock mentioned this pull request Jan 17, 2023
@github-actions
Copy link

🎉 This PR is included in version 20.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants