Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Feat!: Corrected variation and variation option response and update body types #909

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

GeorgeBotzakis
Copy link
Contributor

Type

  • Feature

Description

BREAKING CHANGES:

  • Fix base types for variation and variation options
  • Update body is different from respective base when it comes to the sort_order field. It can include the null value
  • Variation option response type was corrected

@GeorgeBotzakis GeorgeBotzakis changed the title Feat: Corrected variation and variation option response and update body types Feat!: Corrected variation and variation option response and update body types Feb 8, 2024
samblacklock
samblacklock previously approved these changes Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Unit Test Results

    1 files  ±0    55 suites  ±0   2s ⏱️ ±0s
350 tests ±0  350 ✔️ ±0  0 💤 ±0  0 ±0 
355 runs  ±0  355 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 42ac941. ± Comparison against base commit b63ef77.

♻️ This comment has been updated with latest results.

@GeorgeBotzakis GeorgeBotzakis force-pushed the feat/pcm-variation-type-correction branch from e372129 to 42ac941 Compare February 9, 2024 11:23
@GeorgeBotzakis GeorgeBotzakis merged commit a63674b into main Feb 9, 2024
11 checks passed
@GeorgeBotzakis GeorgeBotzakis deleted the feat/pcm-variation-type-correction branch February 9, 2024 11:29
Copy link

github-actions bot commented Feb 9, 2024

🎉 This PR is included in version 28.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants