Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in DOME2D temperature initialization in z and sigma coordinates #1560

Closed
hdrake opened this issue Mar 21, 2022 · 2 comments
Closed

Bug in DOME2D temperature initialization in z and sigma coordinates #1560

hdrake opened this issue Mar 21, 2022 · 2 comments
Labels
bug

Comments

@hdrake
Copy link

hdrake commented Mar 21, 2022

I don't think the following line serves any purpose and in fact inadvertently overwrites the temperature initialization from in the cases where coordinateMode(verticalCoordinate) == REGRIDDING_SIGMA or coordinateMode(verticalCoordinate) == REGRIDDING_ZSTAR

MOM6/src/user/DOME2d_initialization.F90

Line 335 in 399a7db

T(G%isc:G%iec,G%jsc:G%jec,1:GV%ke) = 0.0

@hdrake hdrake mentioned this issue Mar 21, 2022
Closed
@Hallberg-NOAA
Copy link
Collaborator

@hdrake, You are absolutely correct that this line is a bug, but the pull request that was supposed to have fixed it appears to have been closed, not merged, so this bug is still around. Could you please put the corrective pull request in again to https://github.com/NOAA-GFDL/MOM6/pulls. Thanks.

Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Jul 13, 2022
@Hallberg-NOAA
*Fix DOME2d_initialize_temperature_salinity bug
884049d 
  Removed a line resetting temperatures to 0 for the ZSTAR and SIGMA vertical
coordinates in DOME2d_initialize_temperature_salinity, after they had been set
to the intended values.  github.com/mom-ocean/issues/1560 highlights this
bug and can be closed after this commit is merged into the main branch of MOM6.
This changes the temperature fields (and ocean.stats files) for the
flow_downslopes/z and flow_downslopes/sigma test cases, but because temperature
does not influence density in these cases, the flows and salinities are
unchanged.
marshallward pushed a commit to NOAA-GFDL/MOM6 that referenced this issue Jul 17, 2022
@Hallberg-NOAA @marshallward
*Fix DOME2d_initialize_temperature_salinity bug
c2e8465 
  Removed a line resetting temperatures to 0 for the ZSTAR and SIGMA vertical
coordinates in DOME2d_initialize_temperature_salinity, after they had been set
to the intended values.  github.com/mom-ocean/issues/1560 highlights this
bug and can be closed after this commit is merged into the main branch of MOM6.
This changes the temperature fields (and ocean.stats files) for the
flow_downslopes/z and flow_downslopes/sigma test cases, but because temperature
does not influence density in these cases, the flows and salinities are
unchanged.
@Hallberg-NOAA
Copy link
Collaborator

This bug was corrected with NOAA-GFDL#165, which was merged into the main branch of MOM6 on 7/29/2022 as a part of #1577.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hallberg-NOAA @hdrake