[locale] correct translation of locale for Vietnam #4874
Conversation
|
|
chienkira
changed the title
chienkira
changed the title
1 similar comment
|
@bangnk approval? Please edit |
|
@marwahaha Thank you for checking my PR. The check "Generated files — Don't edit moment.js, min/, locale/, build/*." didn't get passed. What else i need to do? |
Hope this helps! |
|
@marwahaha Thank you very much for the details. I have updated PR. |
|
@chienkira can you re-do the last git commit with the same email address? You can set the email address like @bangnk approval? |
|
@marwahaha sorry my bad! I have re-done the commit with github email address. Thank you very much. |
|
@marwahaha Sorry, any update? Is there any reviewer else? |
|
Google Translate: https://glosbe.com/en/vi/last%20week Both seems right but
I was thinking of changing this for Carbon too. But I'm hesitating because of that. @chienkira Are you a native Vietnamese speaker? Are you sure |
|
@kylekatarnls Thank you for checking. Actually I'm a Vietnamese.
Yes I'm sure. We say |
|
@kylekatarnls Google translate is doing well. You can check it here. |
|
Seems also coherent with the current As for what is worth, I'm convinced. |
|
@marwahaha Is there any update? pls |
|
@chienkira This is fine. Would you like to be another locale author? If so, please add your name in the same format underneath @bangnk . |
|
@marwahaha Thank you for checking my PR. Yes I'm very glad to be a locale author.
Sorry but I don't know what should I do exactly? |
|
Please add this line underneath line 3 of |
|
Thank you. I have edited that line. |
* [misc] release process fixes (moment#4961) * Fix locale abbreviation in comment * Update package-lock.json * [misc] Fix type of WeekSpec (moment#4634) * Fix "the the" typo in test (moment#4578) * [locale] Fix moment#4568: Insert punjabi for "next" (moment#4583) * Fix type of WeekSpec You can set `dow` without setting `doy`, so the type should reflect that * [new locale] (oc-lnc) Occitan (moment#4957) * Add oc-lnc files * Fix calendar test * Fix the rest of tests * Add locale author * Dont make changes to package-lock * Add newline at end of file * [bugfix] Fix moment#4962 updateLocale with null to reset (moment#4966) * [locale] es: Add es translation for invalidDate (moment#4560) * Add es translation for invalidDate * Fix lint * [locale] improve mk translation (moment#4958) * Update mk.js * Update mk.js * Update mk.js * Update mk.js * [locale] improve mk translation * [tests] Fix various text typos (moment#4976) * [locale] mr (Marathi) (moment#4990) * tests according to changes in mr.js * [locale] mr (Marathi) We Marathi people follow standards mentioned below, to label timespans. Label | Time Span ------------ | ------------- पहाटे (post midnight, pre-sunrise) | >= 12am to < 6am सकाळी (post sunrise, pre-noon) | >= 6am to < 12pm दुपारी (afternoon) | >= 12pm to < 5pm सायंकाळी (evening) | >= 5pm to < 8pm रात्री (night) | >= 8pm to < 12am Actually, 12am is confusing in Marathi tradition. In modern clock system, Moment 12am is considered in arriving date as 0am. And in Marathi tradition it is referred to as final moment of the previous date (Sort of, 0:01 is starting minute of the arriving date) . To comply with modern clock system, I propose to refer to 0am as पहाटे , so that it is considered as moment in the arriving date. Hope this discription itself is not confusing :) Another point is about range of पहाटे, ie. >= 0am to < 6am. Though conventionally, upto 2 am, we refer to the time as रात्री or पहाटे, both alternatively, I want to specifically call पहाटे for early times in the arriving date and रात्री for late times in the departing date, to make it more specific and well-defined, avoiding confusion about date of the time. * [locale] correct translation of locale for Vietnam (moment#4874) * correct translation of locale for Vietnam * correct translation of locale for Vietnam (edit proper src files) * Update author comment line * [locale] (en-sg) Rename locale en-SG to en-sg (moment#5025) * [locale] typos in Irish locale for months (moment#5127) Fixed some typos in the Irish locale regarding months. * [locale] (br) Breton move from 12-hour to 24-hour notation (moment#4975) * Breton : move from 12-hour to 24-hour notation moment#4974 moment#4974 * Replace [e] by : * [locale] bn: Improve translation as per Bangla Academy (moment#5055) * Delete unused locales * Remove unused locales * Update test and build * Add untracked locale
No description provided.