Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breton : move from 12-hour to 24-hour notation #4974

Closed
jbleduigou opened this issue Jan 28, 2019 · 5 comments
Closed

Breton : move from 12-hour to 24-hour notation #4974

jbleduigou opened this issue Jan 28, 2019 · 5 comments

Comments

@jbleduigou
Copy link
Contributor

jbleduigou commented Jan 28, 2019 •
edited

Breton does not use AM/PM abbreviations
It is weird to see AM and PM being used for Breton language.
I have never seen or heard anyone use it.
When spoken, people use the 12-hour "notation" followed by mintin (morning), goude-merenn (afternoon) or noz (night).
But I believe this would make it less readable for websites or apps.

Solution
Moving to the 24-hour notation would make it both explicit and readable for users.
@marwahaha
Copy link
Member

thoughts @jbleduigou ?

jbleduigou added a commit to jbleduigou/moment that referenced this issue Jan 29, 2019
@jbleduigou
Breton : move from 12-hour to 24-hour notation moment#4974 moment#4974
f246c98
@jbleduigou jbleduigou mentioned this issue Jan 29, 2019
Merged
@jbleduigou
Copy link
Contributor Author

Created pull request : #4975

@ashsearle
Copy link
Contributor

@jbleduigou Are you sure about the [e] in the time format? The unicode survey tool currently shows the preferred option is to use :, as in HH:mm

@jbleduigou
Copy link
Contributor Author

Hi @ashsearle,
It would probably be better with :.
I have committed the changes in my forked repo.
Should I had those changes in the same pull request?

@marwahaha
Copy link
Member

@jbleduigou sure, that's fine.

marwahaha pushed a commit that referenced this issue Jun 10, 2019
@jbleduigou @marwahaha
[locale] (br) Breton move from 12-hour to 24-hour notation (#4975)
63420bc 
* Breton : move from 12-hour to 24-hour notation #4974 #4974

* Replace [e] by :
MhMadHamster pushed a commit to MhMadHamster/moment that referenced this issue Jun 22, 2019
@jbleduigou @MhMadHamster
[locale] (br) Breton move from 12-hour to 24-hour notation (moment#4975)
0e20113 
* Breton : move from 12-hour to 24-hour notation moment#4974 moment#4974

* Replace [e] by :
GmaMontero added a commit to despegar/moment that referenced this issue Sep 4, 2019
@GmaMontero
Remove unused locales (#1)
ab0d313 
* [misc] release process fixes (moment#4961)

* Fix locale abbreviation in comment

* Update package-lock.json

* [misc] Fix type of WeekSpec (moment#4634)

* Fix "the the" typo in test (moment#4578)

* [locale] Fix moment#4568: Insert punjabi for "next" (moment#4583)

* Fix type of WeekSpec

You can set `dow` without setting `doy`, so the type should reflect that

* [new locale] (oc-lnc) Occitan (moment#4957)

* Add oc-lnc files

* Fix calendar test

* Fix the rest of tests

* Add locale author

* Dont make changes to package-lock

* Add newline at end of file

* [bugfix] Fix moment#4962 updateLocale with null to reset (moment#4966)

* [locale] es: Add es translation for invalidDate (moment#4560)

* Add es translation for invalidDate

* Fix lint

* [locale] improve mk translation (moment#4958)

* Update mk.js

* Update mk.js

* Update mk.js

* Update mk.js

* [locale] improve mk translation

* [tests] Fix various text typos (moment#4976)

* [locale] mr (Marathi) (moment#4990)

* tests according to changes in mr.js

* [locale] mr (Marathi)

We Marathi people follow standards mentioned below, to label timespans.

Label | Time Span 
------------ | -------------
पहाटे (post midnight, pre-sunrise) |    >= 12am to < 6am 
सकाळी (post sunrise, pre-noon) |    >= 6am to < 12pm
दुपारी (afternoon) |    >= 12pm to < 5pm
सायंकाळी (evening) |    >= 5pm to < 8pm
रात्री (night) |    >= 8pm to < 12am

Actually, 12am is confusing in Marathi tradition. In modern clock system, Moment 12am is considered in arriving date as 0am. And in Marathi tradition it is referred to as final moment of the previous date (Sort of, 0:01 is starting minute of the arriving date) . To comply with modern clock system, I propose to refer to 0am as पहाटे , so that it is considered as moment in the arriving date. Hope this discription itself is not confusing :)

Another point is about range of पहाटे, ie. >= 0am to < 6am. Though conventionally, upto 2 am, we refer to the time as रात्री or पहाटे, both alternatively, I want to specifically call पहाटे for early times in the arriving date and रात्री for late times in the departing date, to make it more specific and well-defined, avoiding confusion about date of the time.

* [locale] correct translation of locale for Vietnam (moment#4874)

* correct translation of locale for Vietnam

* correct translation of locale for Vietnam (edit proper src files)

* Update author comment line

* [locale] (en-sg) Rename locale en-SG to en-sg (moment#5025)

* [locale] typos in Irish locale for months (moment#5127)

Fixed some typos in the Irish locale regarding months.

* [locale] (br) Breton move from 12-hour to 24-hour notation (moment#4975)

* Breton : move from 12-hour to 24-hour notation moment#4974 moment#4974

* Replace [e] by :

* [locale] bn: Improve translation as per Bangla Academy (moment#5055)

* Delete unused locales

* Remove unused locales

* Update test and build

* Add untracked locale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashsearle @jbleduigou @marwahaha