New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moment creation with object of strings #2721

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@troyastorino
Contributor

troyastorino commented Oct 31, 2015

Fixes problem with parsing Aug 31st for objects with string values (see test for an example of the problem). Analogous behavior to problem in #1870 with arrays

@ichernev

This comment has been minimized.

Contributor

ichernev commented Nov 13, 2015

Looks good. Will merge in next release.

@ichernev ichernev added this to the 2.10.7 milestone Nov 13, 2015

@troyastorino

This comment has been minimized.

Contributor

troyastorino commented Nov 13, 2015

Cool!

@ichernev

This comment has been minimized.

Contributor

ichernev commented Dec 1, 2015

Merged in 3945432

@ichernev ichernev closed this Dec 1, 2015

ichernev added a commit that referenced this pull request Dec 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment