New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new locale] Added Mongolian locale mn #4423

Merged
merged 1 commit into from Mar 4, 2018

Conversation

Projects
None yet
4 participants
@javkhaanj7
Contributor

javkhaanj7 commented Jan 31, 2018

Mongolian locale contributing request.

@jsf-clabot

This comment has been minimized.

jsf-clabot commented Jan 31, 2018

CLA assistant check
All committers have signed the CLA.

@javkhaanj7 javkhaanj7 changed the title from Added Mongolian locale mn to [new locale] Added Mongolian locale mn Jan 31, 2018

@marwahaha

This comment has been minimized.

Member

marwahaha commented Mar 4, 2018

Thank you!

@marwahaha marwahaha merged commit 9272b79 into moment:develop Mar 4, 2018

5 checks passed

Base branch Looks good!
Generated files No edits to generated files! :)
Title Your title looks great!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@henninghall

This comment has been minimized.

henninghall commented Mar 15, 2018

@marwahaha @javkhaanj7 Thanks for the contribution! I am not fully aware of how this project works but aren't a mn.js file also supposed to be copied/generated to "moment/locale/mn.js" and not only "moment/src/locale/mn.js"?

@javkhaanj7

This comment has been minimized.

Contributor

javkhaanj7 commented Mar 15, 2018

@henninghall Thanks. I submitted the PR according to this doc. I think mn.js file will be generated in "moment/locale/" when next version released which done by admin of the repo.

@henninghall

This comment has been minimized.

henninghall commented Mar 15, 2018

Ok, cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment