chore: update to API Key #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
reviewed
Mar 20, 2024
Comment on lines
+7
to
+8
| - A Momento API Key is required, you can generate one using | ||
| the [Momento Console](https://console.gomomento.com) |
There was a problem hiding this comment.
Can you please also mention here that they need to add the token in their .env file like so: MOMENTO_API_KEY=[generated-token]?
There was a problem hiding this comment.
I added here following how we mentioned it in the laravel-example repo.
|
Tests are still running with the Because anyone who has this plugin already in use would have to do the same, this is technically a breaking change. I don't think the adoption of the plugin is such that we need to worry too much about that, but I would like to hear what @cprice404 thinks about it. |
rishtigupta
approved these changes
Mar 21, 2024
cprice404
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the word
auth tokentoAPI key, and also updated the READM to direct users to use our console to generate an API key instead on our CLI which is deprecated.