Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛤️ Rails 7.1 #710

Merged
merged 5 commits into from
Jul 7, 2024
Merged

🛤️ Rails 7.1 #710

merged 5 commits into from
Jul 7, 2024

Conversation

yonta
Copy link
Collaborator

@yonta yonta commented Mar 26, 2024

after #707 #727
close #702

サクッとあがった

やったこと

  • Rails 7.1.3.2 7.1.3.3 7.1.3.4!
  • bundle update

やらなかったこと

  • prod環境用のdockerfileの追加
    • Rails 7.1からDockerfileを自動生成してくれる
      • とても参考にはなる
    • 現状prod環境用のDockerイメージを配布する予定がないので入れない
      • これをやるにはサクッと動くイメージとしたい
      • サクッととは、Coudinary依存なしのこと
      • 手元のコードとPostgreSQLイメージだけで動くくらいの気軽さじゃないと使いづらいよね

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (37fe2c8) to head (759730e).
Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #710   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files          17       17           
  Lines         321      321           
=======================================
  Hits          310      310           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonta yonta changed the title :rail: Rails 7.1 🛤️ Rails 7.1 Mar 27, 2024
@yonta yonta self-assigned this Mar 27, 2024
@yonta
Copy link
Collaborator Author

yonta commented May 30, 2024

もうRuby3.3.2がでてしまった

Copy link

github-actions bot commented Jun 14, 2024

📦 esbuild Bundle Analysis for sakazuki

This analysis was generated by esbuild-bundle-analyzer. 🤖

Meta File Out File Size (raw) Note
meta.json app/assets/builds/application.js 1.01 MB 🆕 Added
Largest paths These visualization shows top 20 largest paths in the bundle.

Meta file: meta.json, Out file: app/assets/builds/application.js

Path Size
node_modules/chart.js/dist ${{\color{Goldenrod}{ ██████▊ }}}$ 27.4%, 273.88 KB
app/javascript/completion ${{\color{Goldenrod}{ ████▎ }}}$ 17.1%, 170.67 KB
node_modules/@hotwired/turbo ${{\color{Goldenrod}{ ███▎ }}}$ 13.2%, 131.96 KB
node_modules/bootstrap/dist ${{\color{Goldenrod}{ ███▏ }}}$ 12.5%, 124.34 KB
node_modules/simplelightbox/dist ${{\color{Goldenrod}{ ██▏ }}}$ 8.8%, 87.73 KB
node_modules/@hotwired/stimulus ${{\color{Goldenrod}{ ██ }}}$ 8.4%, 84.29 KB
node_modules/@popperjs/core ${{\color{Goldenrod}{ █▍ }}}$ 5.6%, 55.66 KB
node_modules/@rails/actioncable ${{\color{Goldenrod}{ ▌ }}}$ 2.0%, 19.51 KB
node_modules/rater-js/index.js ${{\color{Goldenrod}{ ▍ }}}$ 1.6%, 16.42 KB
node_modules/@kurkle/color ${{\color{Goldenrod}{ ▎ }}}$ 1.3%, 13.37 KB
app/javascript/taste_graph ${{\color{Goldenrod}{ ▏ }}}$ 0.8%, 7.56 KB
app/javascript/controllers ${{\color{Goldenrod}{ ▏ }}}$ 0.7%, 6.63 KB
node_modules/@hotwired/turbo-rails ${{\color{Goldenrod}{ }}}$ 0.4%, 3.82 KB
node_modules/ts-deepmerge/esm ${{\color{Goldenrod}{ }}}$ 0.2%, 1.69 KB
node_modules/just-zip-it/index.mjs ${{\color{Goldenrod}{ }}}$ 0.1%, 785 B
node_modules/chart.js/helpers ${{\color{Goldenrod}{ }}}$ 0.0%, 0 B
app/javascript/application.js ${{\color{Goldenrod}{ }}}$ 0.0%, 0 B
Details

Next to the size is how much the size has increased or decreased compared with the base branch of this PR.

  • ‼️: Size increased by 20% or more. Special attention should be given to this.
  • ⚠️: Size increased in acceptable range (lower than 20%).
  • ✅: No change or even downsized.
  • 🗑️: The out file is deleted: not found in base branch.
  • 🆕: The out file is newly found: will be added to base branch.

Rubocopのコンフィグで利用するのを明示しているが、
今まではGemfileには明示していなかった。
今回、bundle exec rubocopでエラーが起こった。
そのためちゃんと明示した。
@yonta
Copy link
Collaborator Author

yonta commented Jun 30, 2024

Ruby3.3.3ではbundleすると依存関係エラーが起こる。
現状はRuby3.3.1のままでRailsのアップデートのPRにする!

@yonta yonta marked this pull request as ready for review June 30, 2024 09:27
@yonta yonta requested a review from momocus June 30, 2024 09:27
Copy link
Owner

@momocus momocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@momocus momocus merged commit e36d34f into main Jul 7, 2024
14 checks passed
@momocus momocus deleted the pr/issue702/rails7.1 branch July 7, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛤Rails7.1
2 participants