Fix mismatched parentheses in QC check #7830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The src/sparql/qc/general/qc-xref-without-source.sparql check had mismatched parentheses which explained why almost no errors where caught correctly. Unfortunately, due to the enormous amount of NCIT and Orphanet errors, I had to drop these from the check..
most of the x-ref had either no source at all, or had EFO as a source. Almost all the x-ref removed are equivalent to another mondo term.
|
@matentzn could we remove all the NCIT and Orphanet computationally? |
sabrinatoro
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
I reviewed the QC fails, and I approve this PR.
The PR can be merged once the QC have passed.
@matentzn Is there something else needed in this PR? or can we merge it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The src/sparql/qc/general/qc-xref-without-source.sparql check had mismatched parentheses which explained why almost no errors where caught correctly. Unfortunately, due to the enormous amount of NCIT and Orphanet errors, I had to drop these from the check..
Fixes #7824
Needs curation now, as more than 60 errors still present. the default solution is to simply delete all of these xrefs from Mondo!