Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When pressing enter, menu doesn't close although passing closeDialogOnContentClick #143

Closed
adirhaz1z opened this issue Jun 8, 2021 · 4 comments · Fixed by #278
Closed

When pressing enter, menu doesn't close although passing closeDialogOnContentClick #143

adirhaz1z opened this issue Jun 8, 2021 · 4 comments · Fixed by #278
Assignees
@lucas-barros
Labels
hacktoberfest

Comments

@adirhaz1z
Copy link
Contributor

No description provided.

@lucas-barros
Copy link
Contributor

@hadasfa may I work on this? Also, the prop name seems to indicate action on "click", should it trigger on "keydown"?

@orrgottlieb
Copy link
Contributor

@lucas-barros , sure you can, I'll assign it to you

@lucas-barros
Copy link
Contributor

@orrgottlieb is closing the dialog on "enter" expected for closeDialogOnContentClick?

@orrgottlieb
Copy link
Contributor

@lucas-barros yes it is, good catch

@lucas-barros lucas-barros mentioned this issue Oct 18, 2021
Merged
11 tasks
talkor pushed a commit that referenced this issue Feb 13, 2024
@ayelethol
add new recycle bin icon (#143)
c768bac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucas-barros lucas-barros

Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
4 participants
@lucas-barros @orrgottlieb @adirhaz1z @hadasfa