🐛 ensure ebs connection config has type filesystem #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
commented
Oct 19, 2023
| @@ -112,7 +112,7 @@ func (blockEntries blockDevices) GetUnmountedBlockEntry() (*fsInfo, error) { | |||
| } | |||
|
|
|||
| func (entry blockDevice) IsNoBootVolume() bool { | |||
| return entry.Uuid != "" && entry.FsType != "" && entry.FsType != "vfat" && entry.Label != "EFI" | |||
| return entry.Uuid != "" && entry.FsType != "" && entry.FsType != "vfat" && entry.Label != "EFI" && entry.Label != "boot" | |||
There was a problem hiding this comment.
this is the reason my tests kept failing so much - i was testing against a rhel machine and i was picking up the boot volume, which we would then of course fail to mount and everything would go a little haywire
vjeffrey
commented
Oct 19, 2023
| @@ -173,6 +173,7 @@ func NewAwsEbsConnection(id uint32, conf *inventory.Config, asset *inventory.Ass | |||
|
|
|||
| // Create and initialize fs provider | |||
| fsConn, err := connection.NewFileSystemConnection(id, &inventory.Config{ | |||
| Type: "filesystem", | |||
There was a problem hiding this comment.
thanks to @czunker for the hint on this one
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picked up this hint from #2171
just trying to get the small we-definitely-want-this pieces in to try to break down this ebs scan issue a bit