Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Fix: Container image pull should be consistent #406

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

mm-weber
Copy link
Contributor

@mm-weber mm-weber commented Jun 11, 2024

Adds props to exclude containers from some checks based on image digest:

    props:
      - uid: excludedByFixedImages
        title: Exclude containers from the check when using fixed images using hash values.
        mql: |
          return [
            # Add container images <image-name>@<digest>
            # image@sha256:45b23dee08af5e43a7fea6c4cf9c25ccf269ee113168c19722f87876677c5cb2
          ]

@mm-weber mm-weber self-assigned this Jun 11, 2024
@mm-weber mm-weber marked this pull request as draft June 11, 2024 13:41
@mm-weber mm-weber changed the title k8s/fix: mondoo-kubernetes-security-pod-imagepull 🧹 Fix: Container image pull should be consistent Jun 11, 2024
@mm-weber mm-weber requested a review from HRouhani June 11, 2024 15:32
@mm-weber mm-weber marked this pull request as ready for review June 11, 2024 15:32
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
@mm-weber mm-weber force-pushed the manuel/fix-k8s-shasum-props branch from f19c47b to 3c3a9c1 Compare June 11, 2024 15:33
Copy link
Contributor

@HRouhani HRouhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Manuel

@HRouhani HRouhani merged commit a141f86 into main Jun 11, 2024
7 checks passed
@HRouhani HRouhani deleted the manuel/fix-k8s-shasum-props branch June 11, 2024 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants