Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Chunk sending results by size #1440

Merged
merged 2 commits into from
Oct 3, 2024
Merged

🐛 Chunk sending results by size #1440

merged 2 commits into from
Oct 3, 2024

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Sep 25, 2024

There is an upper limit to what is accepted by the platform per request. Make sure we do not go past it when sending data.

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Test Results

  1 files  ±0   24 suites  ±0   20s ⏱️ +2s
403 tests ±0  402 ✅ ±0  1 💤 ±0  0 ❌ ±0 
404 runs  ±0  403 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 4f1cfa0. ± Comparison against base commit 0b94fa4.

♻️ This comment has been updated with latest results.

Copy link
Member

@imilchev imilchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we have similar code in cnquery though. It may be a better idea to define the chunking there so we can re-use it in both cnquery and cnspec

@jaym
Copy link
Contributor Author

jaym commented Sep 26, 2024

Do you have specific code in mind?

@jaym jaym force-pushed the jdm/chunk-data-results branch 2 times, most recently from 790d1da to 02251a6 Compare September 26, 2024 10:42
@jaym
Copy link
Contributor Author

jaym commented Oct 3, 2024

mondoohq/cnquery#4711

There is an upper limit to what is accepted by the platform per request.
Make sure we do not go past it when sending data.
Copy link
Member

@imilchev imilchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaym jaym merged commit 38ed514 into main Oct 3, 2024
14 checks passed
@jaym jaym deleted the jdm/chunk-data-results branch October 3, 2024 20:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants